diff options
| author | Armand Philippot <git@armandphilippot.com> | 2023-10-02 17:39:16 +0200 |
|---|---|---|
| committer | Armand Philippot <git@armandphilippot.com> | 2023-11-11 18:14:41 +0100 |
| commit | 6221fa82e41915702d8139cade5c25e9d61e619f (patch) | |
| tree | 9c725b7f7b1e002747712de456c73f28839f0ebd /src/components/organisms/layout | |
| parent | 36890cfafeba6e30782df1260d7f9e678c7da4bf (diff) | |
refactor(components): remove Column and NoScript from atoms
* Column is a simple div meant to be used inside Columns component so
they should live together.
* NoScript is only used in Layout component and its name does not
make sense since it needs to be used inside a `noscript` element.
Diffstat (limited to 'src/components/organisms/layout')
| -rw-r--r-- | src/components/organisms/layout/site-footer.stories.tsx | 3 | ||||
| -rw-r--r-- | src/components/organisms/layout/site-footer.test.tsx | 1 | ||||
| -rw-r--r-- | src/components/organisms/layout/site-footer.tsx | 2 |
3 files changed, 4 insertions, 2 deletions
diff --git a/src/components/organisms/layout/site-footer.stories.tsx b/src/components/organisms/layout/site-footer.stories.tsx index 59a378f..77cc183 100644 --- a/src/components/organisms/layout/site-footer.stories.tsx +++ b/src/components/organisms/layout/site-footer.stories.tsx @@ -1,4 +1,5 @@ import type { ComponentMeta, ComponentStory } from '@storybook/react'; +import { Icon } from '../../atoms'; import { SiteFooter as SiteFooterComponent } from './site-footer'; /** @@ -74,7 +75,7 @@ const Template: ComponentStory<typeof SiteFooterComponent> = (args) => ( const copyright = { dates: { start: '2017', end: '2022' }, owner: 'Lorem ipsum', - icon: 'CC', + icon: <Icon shape="cc-by-sa" />, }; const navItems = [{ id: 'legal-notice', href: '#', label: 'Legal notice' }]; diff --git a/src/components/organisms/layout/site-footer.test.tsx b/src/components/organisms/layout/site-footer.test.tsx index ffdeb7a..0d2cec2 100644 --- a/src/components/organisms/layout/site-footer.test.tsx +++ b/src/components/organisms/layout/site-footer.test.tsx @@ -16,6 +16,7 @@ describe('SiteFooter', () => { it('renders the website copyright', () => { render(<SiteFooter copyright={copyright} topId="top" />); expect(rtlScreen.getByText(copyright.owner)).toBeInTheDocument(); + expect(rtlScreen.getByText(copyright.dates.start)).toBeInTheDocument(); }); it('renders a back to top link', () => { diff --git a/src/components/organisms/layout/site-footer.tsx b/src/components/organisms/layout/site-footer.tsx index c1fe9d0..d767a4d 100644 --- a/src/components/organisms/layout/site-footer.tsx +++ b/src/components/organisms/layout/site-footer.tsx @@ -1,6 +1,6 @@ import type { FC } from 'react'; import { useIntl } from 'react-intl'; -import { Copyright, Footer, type CopyrightProps } from '../../atoms'; +import { Copyright, type CopyrightProps, Footer } from '../../atoms'; import { BackToTop, type BackToTopProps, |