From 6221fa82e41915702d8139cade5c25e9d61e619f Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Mon, 2 Oct 2023 17:39:16 +0200 Subject: refactor(components): remove Column and NoScript from atoms * Column is a simple div meant to be used inside Columns component so they should live together. * NoScript is only used in Layout component and its name does not make sense since it needs to be used inside a `noscript` element. --- src/components/organisms/layout/site-footer.stories.tsx | 3 ++- src/components/organisms/layout/site-footer.test.tsx | 1 + src/components/organisms/layout/site-footer.tsx | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) (limited to 'src/components/organisms/layout') diff --git a/src/components/organisms/layout/site-footer.stories.tsx b/src/components/organisms/layout/site-footer.stories.tsx index 59a378f..77cc183 100644 --- a/src/components/organisms/layout/site-footer.stories.tsx +++ b/src/components/organisms/layout/site-footer.stories.tsx @@ -1,4 +1,5 @@ import type { ComponentMeta, ComponentStory } from '@storybook/react'; +import { Icon } from '../../atoms'; import { SiteFooter as SiteFooterComponent } from './site-footer'; /** @@ -74,7 +75,7 @@ const Template: ComponentStory = (args) => ( const copyright = { dates: { start: '2017', end: '2022' }, owner: 'Lorem ipsum', - icon: 'CC', + icon: , }; const navItems = [{ id: 'legal-notice', href: '#', label: 'Legal notice' }]; diff --git a/src/components/organisms/layout/site-footer.test.tsx b/src/components/organisms/layout/site-footer.test.tsx index ffdeb7a..0d2cec2 100644 --- a/src/components/organisms/layout/site-footer.test.tsx +++ b/src/components/organisms/layout/site-footer.test.tsx @@ -16,6 +16,7 @@ describe('SiteFooter', () => { it('renders the website copyright', () => { render(); expect(rtlScreen.getByText(copyright.owner)).toBeInTheDocument(); + expect(rtlScreen.getByText(copyright.dates.start)).toBeInTheDocument(); }); it('renders a back to top link', () => { diff --git a/src/components/organisms/layout/site-footer.tsx b/src/components/organisms/layout/site-footer.tsx index c1fe9d0..d767a4d 100644 --- a/src/components/organisms/layout/site-footer.tsx +++ b/src/components/organisms/layout/site-footer.tsx @@ -1,6 +1,6 @@ import type { FC } from 'react'; import { useIntl } from 'react-intl'; -import { Copyright, Footer, type CopyrightProps } from '../../atoms'; +import { Copyright, type CopyrightProps, Footer } from '../../atoms'; import { BackToTop, type BackToTopProps, -- cgit v1.2.3