refactor(routes): replace hardcoded routes with constants

It makes it easier to change a route if needed and it avoid typo
mistakes.
I also refactored a bit the concerned files to be complient with the
new ESlint config. However, I should rewrite the pages to reduce
the number of statements.

3 files changed, 37 insertions, 34 deletions

diff --git a/src/utils/helpers/pages.ts b/src/utils/helpers/pages.ts
index 6b27b6d..84854cd 100644
--- a/src/utils/helpers/pages.ts
+++ b/src/utils/helpers/pages.ts
@@ -1,13 +1,14 @@
-import { type LinksListItems, type Post } from '../../components';
+import type { LinksListItems, Post } from '../../components';
 import { getArticleFromRawData } from '../../services/graphql';
-import {
-  type Article,
-  type EdgesResponse,
-  type PageLink,
-  type RawArticle,
-  type RawThematicPreview,
-  type RawTopicPreview,
+import type {
+  Article,
+  EdgesResponse,
+  PageLink,
+  RawArticle,
+  RawThematicPreview,
+  RawTopicPreview,
 } from '../../types';
+import { ROUTES } from '../constants';
 import { getImageFromRawData } from './images';
 
 /**
@@ -25,11 +26,13 @@ export const getPageLinkFromRawData = (
   kind: 'thematic' | 'topic'
 ): PageLink => {
   const { databaseId, featuredImage, slug, title } = data;
-  const baseUrl = kind === 'thematic' ? '/thematique/' : '/sujet/';
+  const baseUrl = `${
+    kind === 'thematic' ? ROUTES.THEMATICS.INDEX : ROUTES.TOPICS
+  }/`;
 
   return {
     id: databaseId,
-    logo: featuredImage ? getImageFromRawData(featuredImage?.node) : undefined,
+    logo: featuredImage ? getImageFromRawData(featuredImage.node) : undefined,
     name: title,
     url: `${baseUrl}${slug}`,
   };
@@ -57,14 +60,13 @@ export const sortPageLinksByName = (a: PageLink, b: PageLink) => {
  * @param {PageLink[]} links - An array of page links.
  * @returns {LinksListItem[]} An array of links items.
  */
-export const getLinksListItems = (links: PageLink[]): LinksListItems[] => {
-  return links.map((link) => {
+export const getLinksListItems = (links: PageLink[]): LinksListItems[] =>
+  links.map((link) => {
     return {
       name: link.name,
       url: link.url,
     };
   });
-};
 
 /**
  * Retrieve the posts list with the article URL.
@@ -72,14 +74,13 @@ export const getLinksListItems = (links: PageLink[]): LinksListItems[] => {
  * @param {Article[]} posts - An array of articles.
  * @returns {Post[]} An array of posts with full article URL.
  */
-export const getPostsWithUrl = (posts: Article[]): Post[] => {
-  return posts.map((post) => {
+export const getPostsWithUrl = (posts: Article[]): Post[] =>
+  posts.map((post) => {
     return {
       ...post,
       url: `/article/${post.slug}`,
     };
   });
-};
 
 /**
  * Retrieve the posts list from raw data.
@@ -89,11 +90,11 @@ export const getPostsWithUrl = (posts: Article[]): Post[] => {
  */
 export const getPostsList = (rawData: EdgesResponse<RawArticle>[]): Post[] => {
   const articlesList: RawArticle[] = [];
-  rawData.forEach((articleData) =>
+  rawData.forEach((articleData) => {
     articleData.edges.forEach((edge) => {
       articlesList.push(edge.node);
-    })
-  );
+    });
+  });
 
   return getPostsWithUrl(
     articlesList.map((article) => getArticleFromRawData(article))
diff --git a/src/utils/helpers/rss.ts b/src/utils/helpers/rss.ts
index 28f3c7b..0381c68 100644
--- a/src/utils/helpers/rss.ts
+++ b/src/utils/helpers/rss.ts
@@ -4,8 +4,9 @@ import {
   getArticles,
   getTotalArticles,
 } from '../../services/graphql';
-import { type Article } from '../../types';
-import { settings } from '../../utils/config';
+import type { Article } from '../../types';
+import { settings } from '../config';
+import { ROUTES } from '../constants';
 
 /**
  * Retrieve the data for all the articles.
@@ -17,9 +18,9 @@ const getAllArticles = async (): Promise<Article[]> => {
   const rawArticles = await getArticles({ first: totalArticles });
   const articles: Article[] = [];
 
-  rawArticles.edges.forEach((edge) =>
-    articles.push(getArticleFromRawData(edge.node))
-  );
+  rawArticles.edges.forEach((edge) => {
+    articles.push(getArticleFromRawData(edge.node));
+  });
 
   return articles;
 };
@@ -43,8 +44,8 @@ export const generateFeed = async (): Promise<Feed> => {
     copyright,
     description: process.env.APP_FEED_DESCRIPTION,
     feedLinks: {
-      json: `${settings.url}/feed/json`,
-      atom: `${settings.url}/feed/atom`,
+      json: `${settings.url}${ROUTES.RSS}/json`,
+      atom: `${settings.url}${ROUTES.RSS}/atom`,
     },
     generator: 'Feed & NextJS',
     id: settings.url,
@@ -58,10 +59,10 @@ export const generateFeed = async (): Promise<Feed> => {
   articles.forEach((article) => {
     feed.addItem({
       content: article.intro,
-      date: new Date(article.meta!.dates.publication),
+      date: new Date(article.meta.dates.publication),
       description: article.intro,
       id: `${article.id}`,
-      link: `${settings.url}/article/${article.slug}`,
+      link: `${settings.url}${ROUTES.ARTICLE}/${article.slug}`,
       title: article.title,
     });
   });
diff --git a/src/utils/helpers/schema-org.ts b/src/utils/helpers/schema-org.ts
index 82f99c2..12bad28 100644
--- a/src/utils/helpers/schema-org.ts
+++ b/src/utils/helpers/schema-org.ts
@@ -1,4 +1,4 @@
-import {
+import type {
   AboutPage,
   Article,
   Blog,
@@ -7,8 +7,9 @@ import {
   Graph,
   WebPage,
 } from 'schema-dts';
-import { type Dates } from '../../types';
-import { settings } from '../../utils/config';
+import type { Dates } from '../../types';
+import { settings } from '../config';
+import { ROUTES } from '../constants';
 
 export type GetBlogSchemaProps = {
   /**
@@ -146,7 +147,7 @@ export const getSinglePageSchema = <T extends SinglePageSchemaKind>({
     copyrightYear: publicationDate.getFullYear(),
     creator: { '@id': `${settings.url}/#branding` },
     dateCreated: publicationDate.toISOString(),
-    dateModified: updateDate && updateDate.toISOString(),
+    dateModified: updateDate?.toISOString(),
     datePublished: publicationDate.toISOString(),
     editor: { '@id': `${settings.url}/#branding` },
     headline: title,
@@ -157,7 +158,7 @@ export const getSinglePageSchema = <T extends SinglePageSchemaKind>({
     isPartOf:
       kind === 'post'
         ? {
-            '@id': `${settings.url}/blog`,
+            '@id': `${settings.url}${ROUTES.BLOG}`,
           }
         : undefined,
     mainEntityOfPage: { '@id': `${settings.url}${slug}` },
@@ -206,7 +207,7 @@ export const getWebPageSchema = ({
     breadcrumb: { '@id': `${settings.url}/#breadcrumb` },
     lastReviewed: updateDate,
     name: title,
-    description: description,
+    description,
     inLanguage: locale,
     reviewedBy: { '@id': `${settings.url}/#branding` },
     url: `${settings.url}${slug}`,