diff options
| author | Armand Philippot <git@armandphilippot.com> | 2022-02-16 15:34:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-16 15:34:06 +0100 |
| commit | a9dce097f6a076f243869a495d9ab6d9ddf6ecd2 (patch) | |
| tree | 6794b49e86b00a00539e2326994ec73e8fd845e6 /src/components | |
| parent | 588f76ecaaaa80159dbbadce9603f2da32953b3a (diff) | |
fix: make schema.org markup valid (#4)
Squashed commit of the following:
commit 49c1b3b1556a0eb91c429a961fedd2bded8ffd47
Author: Armand Philippot <git@armandphilippot.com>
Date: Wed Feb 16 15:17:52 2022 +0100
chore: add headline field to blogPosting schema
commit 42214c6f032cc899ec252a9387be35dcad738546
Author: Armand Philippot <git@armandphilippot.com>
Date: Wed Feb 16 15:09:11 2022 +0100
chore: update the searchAction markup and add query-input
Google was complaining about "query-input" which is not in Schema.org
representation. So I added it.
commit 5f29226d937cbdcd262df2793f1588435d850f02
Author: Armand Philippot <git@armandphilippot.com>
Date: Wed Feb 16 14:32:14 2022 +0100
chore: remove breadcrumb from homepage
The breadcrumb is not displayed on the homepage, so the breadcrumb
field should not appear inside Schema markup.
Diffstat (limited to 'src/components')
| -rw-r--r-- | src/components/Form/Form.tsx | 4 | ||||
| -rw-r--r-- | src/components/Layouts/Layout.tsx | 26 | ||||
| -rw-r--r-- | src/components/PostPreview/PostPreview.tsx | 1 | ||||
| -rw-r--r-- | src/components/SearchForm/SearchForm.tsx | 2 |
4 files changed, 25 insertions, 8 deletions
diff --git a/src/components/Form/Form.tsx b/src/components/Form/Form.tsx index 74a4efb..44763c4 100644 --- a/src/components/Form/Form.tsx +++ b/src/components/Form/Form.tsx @@ -5,16 +5,18 @@ const Form = ({ children, submitHandler, modifier = '', + id, }: { children: ReactNode; submitHandler: any; modifier?: string; + id?: string; }) => { const withModifier = modifier ? styles[`wrapper--${modifier}`] : ''; const classes = `${styles.wrapper} ${withModifier}`; return ( - <form onSubmit={submitHandler} className={classes}> + <form onSubmit={submitHandler} className={classes} id={id}> {children} </form> ); diff --git a/src/components/Layouts/Layout.tsx b/src/components/Layouts/Layout.tsx index eb725d2..d529efe 100644 --- a/src/components/Layouts/Layout.tsx +++ b/src/components/Layouts/Layout.tsx @@ -7,7 +7,7 @@ import Head from 'next/head'; import { useRouter } from 'next/router'; import { ReactElement, ReactNode, useEffect, useRef } from 'react'; import { useIntl } from 'react-intl'; -import { WebSite, WithContext } from 'schema-dts'; +import { SearchAction, WebSite, WithContext } from 'schema-dts'; import styles from './Layout.module.scss'; const Layout = ({ @@ -40,11 +40,19 @@ const Layout = ({ creator: { '@id': `${settings.url}/#branding` }, editor: { '@id': `${settings.url}/#branding` }, inLanguage: settings.locales.defaultLocale, - potentialAction: { - '@type': 'SearchAction', - target: `${settings.url}/recherche?s={query}`, - query: 'required', - }, + potentialAction: { '@id': `${settings.url}/#search` }, + }; + + type QueryAction = SearchAction & { + 'query-input': string; + }; + + const searchActionSchema: QueryAction = { + '@type': 'SearchAction', + '@id': `${settings.url}/#search`, + target: `${settings.url}/recherche?s={query}`, + query: 'required', + 'query-input': 'required name=query', }; return ( @@ -94,6 +102,12 @@ const Layout = ({ type="application/ld+json" dangerouslySetInnerHTML={{ __html: JSON.stringify(schemaJsonLd) }} ></script> + <script + type="application/ld+json" + dangerouslySetInnerHTML={{ + __html: JSON.stringify(searchActionSchema), + }} + ></script> </Head> <noscript> <div className={styles['noscript-spacing']}></div> diff --git a/src/components/PostPreview/PostPreview.tsx b/src/components/PostPreview/PostPreview.tsx index 0be9709..3fbfa63 100644 --- a/src/components/PostPreview/PostPreview.tsx +++ b/src/components/PostPreview/PostPreview.tsx @@ -57,6 +57,7 @@ const PostPreview = ({ dateModified: updateDate.toISOString(), datePublished: publicationDate.toISOString(), editor: { '@id': `${settings.url}/#branding` }, + headline: title, image: featuredImage?.sourceUrl, inLanguage: settings.locales.defaultLocale, isBasedOn: `${settings.url}/article/${slug}`, diff --git a/src/components/SearchForm/SearchForm.tsx b/src/components/SearchForm/SearchForm.tsx index da6f25c..fa3ad07 100644 --- a/src/components/SearchForm/SearchForm.tsx +++ b/src/components/SearchForm/SearchForm.tsx @@ -34,7 +34,7 @@ const SearchForm = ({ isOpened }: { isOpened: boolean }) => { description: 'SearchForm : form title', })} </div> - <Form submitHandler={launchSearch} modifier="search"> + <Form submitHandler={launchSearch} modifier="search" id="search"> <label htmlFor="search-query" className="screen-reader-text"> {intl.formatMessage({ defaultMessage: 'Keywords:', |
