diff options
| author | Armand Philippot <git@armandphilippot.com> | 2023-11-30 19:30:43 +0100 |
|---|---|---|
| committer | Armand Philippot <git@armandphilippot.com> | 2023-12-01 16:08:54 +0100 |
| commit | 5b762b1b669454a89899c4bdf6008027d9615acf (patch) | |
| tree | 37087f4ee9d14ae131bde15a48d7d04e83ae6cbd /src/components/organisms/comment | |
| parent | f7e6f42216c3cbeab9add475a61bb407c6be3519 (diff) | |
refactor(pages): refine Article pages
* use rehype to update code blocks class names
* fix widget heading level (after a level 1 it should always be a level
2 and not 3)
* replace Spinner with LoadingPage and LoadingPageComments components to
keep layout coherent
* refactor useArticle and useComments hooks
* fix URLs in JSON LD schema
* add Cypress tests
Diffstat (limited to 'src/components/organisms/comment')
| -rw-r--r-- | src/components/organisms/comment/approved-comment/approved-comment.test.tsx | 4 | ||||
| -rw-r--r-- | src/components/organisms/comment/approved-comment/approved-comment.tsx | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/src/components/organisms/comment/approved-comment/approved-comment.test.tsx b/src/components/organisms/comment/approved-comment/approved-comment.test.tsx index 2e29b5f..b244a63 100644 --- a/src/components/organisms/comment/approved-comment/approved-comment.test.tsx +++ b/src/components/organisms/comment/approved-comment/approved-comment.test.tsx @@ -52,7 +52,9 @@ describe('ApprovedComment', () => { /> ); - expect(rtlScreen.getByRole('img')).toHaveAccessibleName(author.avatar.alt); + expect(rtlScreen.getByRole('figure')).toHaveAccessibleName( + author.avatar.alt + ); }); it('can render a link to the author website', () => { diff --git a/src/components/organisms/comment/approved-comment/approved-comment.tsx b/src/components/organisms/comment/approved-comment/approved-comment.tsx index 233146d..d834ba3 100644 --- a/src/components/organisms/comment/approved-comment/approved-comment.tsx +++ b/src/components/organisms/comment/approved-comment/approved-comment.tsx @@ -117,9 +117,10 @@ const ApprovedCommentWithRef: ForwardRefRenderFunction< className={commentClass} cover={ author.avatar ? ( - <CardCover hasBorders> + <CardCover aria-label={author.avatar.alt} hasBorders> <NextImage - alt={author.avatar.alt} + // eslint-disable-next-line react/jsx-no-literals + alt="" height={96} src={author.avatar.src} width={96} |