diff options
| author | Armand Philippot <git@armandphilippot.com> | 2022-06-02 19:03:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-02 19:03:33 +0200 |
| commit | a8af53c118478e6ed68975c32cc1202b7c7b798e (patch) | |
| tree | e8baa78566523de3d3533f0815efb375a00878d9 /src/components/molecules/forms/prism-theme-toggle.tsx | |
| parent | 329d5ab3f49d663f40a965af4d29eaa38b9a4a86 (diff) | |
| parent | d7fa0a16bebbb58e842f28396a0973f16a060996 (diff) | |
fix: improve settings accessibility (#18)
The settings modal had some accessibility issues:
* the SVG title was not used as radio button label,
* the state of the help button was only visual.
Diffstat (limited to 'src/components/molecules/forms/prism-theme-toggle.tsx')
| -rw-r--r-- | src/components/molecules/forms/prism-theme-toggle.tsx | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/components/molecules/forms/prism-theme-toggle.tsx b/src/components/molecules/forms/prism-theme-toggle.tsx index 7bf5b7c..0fd9f54 100644 --- a/src/components/molecules/forms/prism-theme-toggle.tsx +++ b/src/components/molecules/forms/prism-theme-toggle.tsx @@ -80,13 +80,23 @@ const PrismThemeToggle: FC<PrismThemeToggleProps> = (props) => { const options: RadioGroupOption[] = [ { id: 'code-blocks-light', - label: <Sun title={lightThemeLabel} />, + label: ( + <> + <span className="screen-reader-text">{lightThemeLabel}</span> + <Sun /> + </> + ), name: 'code-blocks', value: 'light', }, { id: 'code-blocks-dark', - label: <Moon title={darkThemeLabel} />, + label: ( + <> + <span className="screen-reader-text">{darkThemeLabel}</span> + <Moon /> + </> + ), name: 'code-blocks', value: 'dark', }, |