aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArmand Philippot <git@armandphilippot.com>2022-05-18 22:43:22 +0200
committerArmand Philippot <git@armandphilippot.com>2022-05-18 22:43:22 +0200
commit30d3489ca15b3ec16b93c312b0f517cd1bead1cd (patch)
tree7e85067757a38f5d756c83ab1d7ef5536703e9dd
parent584bd42f871d2e1618ca414749f09c38f0143a44 (diff)
chore: fix minor styles/typescript issues introduced during refactoring
-rw-r--r--__tests__/utils/test-utils.tsx3
-rw-r--r--src/components/molecules/layout/card.module.scss3
-rw-r--r--src/components/molecules/layout/card.tsx6
-rw-r--r--src/components/organisms/layout/overview.tsx1
-rw-r--r--src/components/templates/page/page-layout.test.tsx1
5 files changed, 10 insertions, 4 deletions
diff --git a/__tests__/utils/test-utils.tsx b/__tests__/utils/test-utils.tsx
index 00123c3..1bcea8e 100644
--- a/__tests__/utils/test-utils.tsx
+++ b/__tests__/utils/test-utils.tsx
@@ -1,9 +1,10 @@
import { render, RenderOptions } from '@testing-library/react';
import { ThemeProvider } from 'next-themes';
-import { FC, ReactElement } from 'react';
+import { FC, ReactElement, ReactNode } from 'react';
import { IntlProvider } from 'react-intl';
type ProvidersConfig = {
+ children: ReactNode;
locale?: 'en' | 'fr';
};
diff --git a/src/components/molecules/layout/card.module.scss b/src/components/molecules/layout/card.module.scss
index 3af8f24..6065642 100644
--- a/src/components/molecules/layout/card.module.scss
+++ b/src/components/molecules/layout/card.module.scss
@@ -33,7 +33,8 @@
.title {
flex: 1;
- margin: var(--spacing-sm) 0;
+ margin-top: var(--spacing-sm);
+ margin-bottom: var(--spacing-sm);
}
h2.title {
diff --git a/src/components/molecules/layout/card.tsx b/src/components/molecules/layout/card.tsx
index e416bd5..003060f 100644
--- a/src/components/molecules/layout/card.tsx
+++ b/src/components/molecules/layout/card.tsx
@@ -87,7 +87,11 @@ const Card: FC<CardProps> = ({
className={styles.cover}
/>
)}
- <Heading level={titleLevel} className={styles.title}>
+ <Heading
+ alignment="center"
+ level={titleLevel}
+ className={styles.title}
+ >
{title}
</Heading>
</header>
diff --git a/src/components/organisms/layout/overview.tsx b/src/components/organisms/layout/overview.tsx
index 55ad0b5..d49dee1 100644
--- a/src/components/organisms/layout/overview.tsx
+++ b/src/components/organisms/layout/overview.tsx
@@ -43,7 +43,6 @@ const Overview: FC<OverviewProps> = ({ className = '', cover, meta }) => {
<div className={`${styles.wrapper} ${className}`}>
{cover && (
<ResponsiveImage
- layout="responsive"
objectFit="contain"
className={styles.cover}
{...cover}
diff --git a/src/components/templates/page/page-layout.test.tsx b/src/components/templates/page/page-layout.test.tsx
index b3aea8b..a414e14 100644
--- a/src/components/templates/page/page-layout.test.tsx
+++ b/src/components/templates/page/page-layout.test.tsx
@@ -107,6 +107,7 @@ describe('PageLayout', () => {
breadcrumb={breadcrumb}
breadcrumbSchema={breadcrumbSchema}
title={title}
+ allowComments={true}
comments={comments}
>
{children}