From 0f38aee374029213a47ef7c29bd164093fe63c85 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Wed, 15 Nov 2023 12:24:42 +0100 Subject: refactor(hooks): remove useSettings hook It does not make sense to re-export an existing object through a hook. On some pages both the hook and the object was imported... It is better to use the CONFIG (previously settings) object directly and by doing it we avoid potential errors because of conditional hooks. --- tests/cypress/e2e/pages/blog.cy.ts | 6 +++--- tests/cypress/e2e/pages/homepage.cy.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'tests/cypress') diff --git a/tests/cypress/e2e/pages/blog.cy.ts b/tests/cypress/e2e/pages/blog.cy.ts index 2ec14c2..3a422d2 100644 --- a/tests/cypress/e2e/pages/blog.cy.ts +++ b/tests/cypress/e2e/pages/blog.cy.ts @@ -1,4 +1,4 @@ -import { settings } from '../../../../src/utils/config'; +import { CONFIG } from '../../../../src/utils/config'; import { ROUTES } from '../../../../src/utils/constants'; type ArticlesGroup = { @@ -27,10 +27,10 @@ describe('Blog Page', () => { : { first: '0', total: '0' }; const totalArticles = parseInt(total, 10); - expect(parseInt(first, 10)).to.be.within(1, settings.postsPerPage); + expect(parseInt(first, 10)).to.be.within(1, CONFIG.postsPerPage); expect(totalArticles).to.be.at.least(1); - const totalPages = Math.ceil(totalArticles / settings.postsPerPage); + const totalPages = Math.ceil(totalArticles / CONFIG.postsPerPage); const remainingPages = totalPages - 1; return Array.from({ length: remainingPages }, (_, i) => i + 1); diff --git a/tests/cypress/e2e/pages/homepage.cy.ts b/tests/cypress/e2e/pages/homepage.cy.ts index 8cd58cb..2d95767 100644 --- a/tests/cypress/e2e/pages/homepage.cy.ts +++ b/tests/cypress/e2e/pages/homepage.cy.ts @@ -1,9 +1,9 @@ -import { settings } from '../../../../src/utils/config'; +import { CONFIG } from '../../../../src/utils/config'; describe('HomePage', () => { it('successfully loads', () => { cy.visit('/'); - cy.findByRole('heading', { level: 1 }).contains(settings.name); - cy.findByText(settings.baseline.fr).should('exist'); + cy.findByRole('heading', { level: 1 }).contains(CONFIG.name); + cy.findByText(CONFIG.baseline).should('exist'); }); }); -- cgit v1.2.3