From f111685c5886f3e77edfd3621c98d8ac1b9bcce4 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Fri, 24 Nov 2023 20:00:08 +0100 Subject: refactor(services, types): reorganize GraphQL fetchers and data types The Typescript mapped types was useful for autocompletion in fetchers but their are harder to maintain. I think it's better to keep each query close to its fetcher to have a better understanding of the fetched data. So I: * colocate queries with their own fetcher * colocate mutations with their own mutator * remove Typescript mapped types for queries and mutations * move data convertors inside graphql services * rename most of data types and fetchers --- src/utils/helpers/rss.ts | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) (limited to 'src/utils/helpers/rss.ts') diff --git a/src/utils/helpers/rss.ts b/src/utils/helpers/rss.ts index d9c3b1e..82fa1ee 100644 --- a/src/utils/helpers/rss.ts +++ b/src/utils/helpers/rss.ts @@ -1,28 +1,25 @@ import { Feed } from 'feed'; import { - getArticleFromRawData, - getArticles, - getTotalArticles, + convertPostPreviewToArticlePreview, + fetchPostsList, + fetchPostsCount, } from '../../services/graphql'; -import type { Article } from '../../types'; +import type { ArticlePreview } from '../../types'; import { CONFIG } from '../config'; import { ROUTES } from '../constants'; /** * Retrieve the data for all the articles. * - * @returns {Promise} - All the articles. + * @returns {Promise} - All the articles. */ -const getAllArticles = async (): Promise => { - const totalArticles = await getTotalArticles(); - const rawArticles = await getArticles({ first: totalArticles }); - const articles: Article[] = []; +const getAllArticles = async (): Promise => { + const totalPosts = await fetchPostsCount(); + const posts = await fetchPostsList({ first: totalPosts }); - rawArticles.edges.forEach(async (edge) => { - articles.push(await getArticleFromRawData(edge.node)); - }); - - return articles; + return posts.edges.map((edge) => + convertPostPreviewToArticlePreview(edge.node) + ); }; /** -- cgit v1.2.3