From f111685c5886f3e77edfd3621c98d8ac1b9bcce4 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Fri, 24 Nov 2023 20:00:08 +0100 Subject: refactor(services, types): reorganize GraphQL fetchers and data types The Typescript mapped types was useful for autocompletion in fetchers but their are harder to maintain. I think it's better to keep each query close to its fetcher to have a better understanding of the fetched data. So I: * colocate queries with their own fetcher * colocate mutations with their own mutator * remove Typescript mapped types for queries and mutations * move data convertors inside graphql services * rename most of data types and fetchers --- .../helpers/convert-wp-image-to-img.test.ts | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 src/services/graphql/helpers/convert-wp-image-to-img.test.ts (limited to 'src/services/graphql/helpers/convert-wp-image-to-img.test.ts') diff --git a/src/services/graphql/helpers/convert-wp-image-to-img.test.ts b/src/services/graphql/helpers/convert-wp-image-to-img.test.ts new file mode 100644 index 0000000..ca58a4f --- /dev/null +++ b/src/services/graphql/helpers/convert-wp-image-to-img.test.ts @@ -0,0 +1,41 @@ +import { describe, expect, it } from '@jest/globals'; +import type { WPImage } from '../../../types'; +import { convertWPImgToImg } from './convert-wp-image-to-img'; + +describe('convert-wp-image-to-img', () => { + it('converts a WPImage object to an Img object', () => { + const img: WPImage = { + altText: 'molestiae praesentium animi', + mediaDetails: { + height: 480, + width: 640, + }, + sourceUrl: 'https://picsum.photos/640/480', + title: null, + }; + + const transformedImg = convertWPImgToImg(img); + + expect(transformedImg.alt).toBe(img.altText); + expect(transformedImg.height).toBe(img.mediaDetails.height); + expect(transformedImg.src).toBe(img.sourceUrl); + expect(transformedImg.title).toBeUndefined(); + expect(transformedImg.width).toBe(img.mediaDetails.width); + }); + + it('can return an empty string if altText is missing', () => { + const img: WPImage = { + altText: null, + mediaDetails: { + height: 480, + width: 640, + }, + sourceUrl: 'https://picsum.photos/640/480', + title: null, + }; + + const transformedImg = convertWPImgToImg(img); + + expect(transformedImg.alt).toBe(''); + }); +}); -- cgit v1.2.3