From f111685c5886f3e77edfd3621c98d8ac1b9bcce4 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Fri, 24 Nov 2023 20:00:08 +0100 Subject: refactor(services, types): reorganize GraphQL fetchers and data types The Typescript mapped types was useful for autocompletion in fetchers but their are harder to maintain. I think it's better to keep each query close to its fetcher to have a better understanding of the fetched data. So I: * colocate queries with their own fetcher * colocate mutations with their own mutator * remove Typescript mapped types for queries and mutations * move data convertors inside graphql services * rename most of data types and fetchers --- .../helpers/convert-taxonomy-to-page-link.test.ts | 52 ++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 src/services/graphql/helpers/convert-taxonomy-to-page-link.test.ts (limited to 'src/services/graphql/helpers/convert-taxonomy-to-page-link.test.ts') diff --git a/src/services/graphql/helpers/convert-taxonomy-to-page-link.test.ts b/src/services/graphql/helpers/convert-taxonomy-to-page-link.test.ts new file mode 100644 index 0000000..b687ccb --- /dev/null +++ b/src/services/graphql/helpers/convert-taxonomy-to-page-link.test.ts @@ -0,0 +1,52 @@ +import { describe, expect, it } from '@jest/globals'; +import type { WPThematicPreview, WPTopicPreview } from '../../../types'; +import { convertTaxonomyToPageLink } from './convert-taxonomy-to-page-link'; + +describe('convert-taxonomy-to-page-link', () => { + it('can convert a WPThematicPreview object to a Thematic object', () => { + const thematic: WPThematicPreview = { + databaseId: 42, + slug: '/the-thematic-slug', + title: 'et ut alias', + }; + const result = convertTaxonomyToPageLink(thematic); + + expect(result.id).toBe(thematic.databaseId); + expect(result.logo).toBeUndefined(); + expect(result.name).toBe(thematic.title); + expect(result.url).toBe(thematic.slug); + }); + + it('can convert a WPTopicPreview object to a Topic object', () => { + const topic: WPTopicPreview = { + databaseId: 42, + featuredImage: { + node: { + altText: 'dolorem quia possimus', + mediaDetails: { + height: 480, + width: 640, + }, + sourceUrl: 'https://picsum.photos/640/480', + title: 'eos', + }, + }, + slug: '/the-topic-slug', + title: 'et ut alias', + }; + const result = convertTaxonomyToPageLink(topic); + + expect(result.id).toBe(topic.databaseId); + expect(result.logo?.alt).toBe(topic.featuredImage?.node.altText); + expect(result.logo?.height).toBe( + topic.featuredImage?.node.mediaDetails.height + ); + expect(result.logo?.src).toBe(topic.featuredImage?.node.sourceUrl); + expect(result.logo?.title).toBe(topic.featuredImage?.node.title); + expect(result.logo?.width).toBe( + topic.featuredImage?.node.mediaDetails.width + ); + expect(result.name).toBe(topic.title); + expect(result.url).toBe(topic.slug); + }); +}); -- cgit v1.2.3