From f111685c5886f3e77edfd3621c98d8ac1b9bcce4 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Fri, 24 Nov 2023 20:00:08 +0100 Subject: refactor(services, types): reorganize GraphQL fetchers and data types The Typescript mapped types was useful for autocompletion in fetchers but their are harder to maintain. I think it's better to keep each query close to its fetcher to have a better understanding of the fetched data. So I: * colocate queries with their own fetcher * colocate mutations with their own mutator * remove Typescript mapped types for queries and mutations * move data convertors inside graphql services * rename most of data types and fetchers --- .../convert-recent-post-to-recent-article.test.ts | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 src/services/graphql/helpers/convert-recent-post-to-recent-article.test.ts (limited to 'src/services/graphql/helpers/convert-recent-post-to-recent-article.test.ts') diff --git a/src/services/graphql/helpers/convert-recent-post-to-recent-article.test.ts b/src/services/graphql/helpers/convert-recent-post-to-recent-article.test.ts new file mode 100644 index 0000000..8acf753 --- /dev/null +++ b/src/services/graphql/helpers/convert-recent-post-to-recent-article.test.ts @@ -0,0 +1,48 @@ +import { describe, expect, it } from '@jest/globals'; +import type { RecentWPPost } from '../../../types'; +import { convertRecentPostToRecentArticle } from './convert-recent-post-to-recent-article'; +import { convertWPImgToImg } from './convert-wp-image-to-img'; + +describe('convert-recent-post-to-recent-article', () => { + it('converts a RecentWPPost object to a RecentArticle object', () => { + const post: RecentWPPost = { + databaseId: 5, + date: '2022-03-20', + featuredImage: null, + slug: '/the-post-slug', + title: 'veritatis ex autem', + }; + const result = convertRecentPostToRecentArticle(post); + + expect(result.cover).toBeUndefined(); + expect(result.id).toBe(post.databaseId); + expect(result.publicationDate).toBe(post.date); + expect(result.slug).toBe(post.slug); + expect(result.title).toBe(post.title); + }); + + it('can convert the cover', () => { + const post = { + databaseId: 5, + date: '2022-03-20', + featuredImage: { + node: { + altText: 'molestiae praesentium animi', + mediaDetails: { + height: 480, + width: 640, + }, + sourceUrl: 'https://picsum.photos/640/480', + title: 'ullam deserunt perspiciatis', + }, + }, + slug: '/the-post-slug', + title: 'veritatis ex autem', + } satisfies RecentWPPost; + const result = convertRecentPostToRecentArticle(post); + + expect(result.cover).toStrictEqual( + convertWPImgToImg(post.featuredImage.node) + ); + }); +}); -- cgit v1.2.3