From 5b762b1b669454a89899c4bdf6008027d9615acf Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Thu, 30 Nov 2023 19:30:43 +0100 Subject: refactor(pages): refine Article pages * use rehype to update code blocks class names * fix widget heading level (after a level 1 it should always be a level 2 and not 3) * replace Spinner with LoadingPage and LoadingPageComments components to keep layout coherent * refactor useArticle and useComments hooks * fix URLs in JSON LD schema * add Cypress tests --- src/i18n/en.json | 20 ++++++++++++++++---- src/i18n/fr.json | 20 ++++++++++++++++---- 2 files changed, 32 insertions(+), 8 deletions(-) (limited to 'src/i18n') diff --git a/src/i18n/en.json b/src/i18n/en.json index be67b38..671e2b1 100644 --- a/src/i18n/en.json +++ b/src/i18n/en.json @@ -39,6 +39,10 @@ "defaultMessage": "Written by:", "description": "PageHeader: author meta label" }, + "0UzObH": { + "defaultMessage": "The requested page is loading...", + "description": "LoadingPage: loading message" + }, "0f7fty": { "defaultMessage": "Share on Diaspora", "description": "SharingWidget: Diaspora sharing link" @@ -103,10 +107,6 @@ "defaultMessage": "Page not found.", "description": "404Page: SEO - Meta description" }, - "4iYISO": { - "defaultMessage": "Loading the requested article...", - "description": "ArticlePage: loading article message" - }, "5C+1PP": { "defaultMessage": "Blog", "description": "SiteNavbar: main nav - blog link" @@ -399,6 +399,10 @@ "defaultMessage": "It has been approved.", "description": "PageComments: comment approved." }, + "VTJE8h": { + "defaultMessage": "{author}'s avatar", + "description": "Article: accessible name for the comment avatar" + }, "VkAnvv": { "defaultMessage": "Send", "description": "ContactForm: send button" @@ -523,6 +527,10 @@ "defaultMessage": "Code blocks:", "description": "PrismThemeToggle: theme label" }, + "gYbxP4": { + "defaultMessage": "The comments are loading...", + "description": "LoadingPageComments: loading message" + }, "hGvQpI": { "defaultMessage": "Load more posts?", "description": "PostsList: load more button" @@ -619,6 +627,10 @@ "defaultMessage": "Discover search results for {query} on {websiteName}.", "description": "SearchPage: SEO - Meta description" }, + "s57FTB": { + "defaultMessage": "Share", + "description": "Article: sharing widget title" + }, "s8/tyz": { "defaultMessage": "Object:", "description": "ContactForm: object label" diff --git a/src/i18n/fr.json b/src/i18n/fr.json index 0226f1e..c8b4058 100644 --- a/src/i18n/fr.json +++ b/src/i18n/fr.json @@ -39,6 +39,10 @@ "defaultMessage": "Écrit par :", "description": "PageHeader: author meta label" }, + "0UzObH": { + "defaultMessage": "La page est en cours de chargement…", + "description": "LoadingPage: loading message" + }, "0f7fty": { "defaultMessage": "Partager sur Diaspora", "description": "SharingWidget: Diaspora sharing link" @@ -103,10 +107,6 @@ "defaultMessage": "Page non trouvée.", "description": "404Page: SEO - Meta description" }, - "4iYISO": { - "defaultMessage": "Chargement de l’article demandé…", - "description": "ArticlePage: loading article message" - }, "5C+1PP": { "defaultMessage": "Blog", "description": "SiteNavbar: main nav - blog link" @@ -399,6 +399,10 @@ "defaultMessage": "Il a été approuvé.", "description": "PageComments: comment approved." }, + "VTJE8h": { + "defaultMessage": "Avatar de {author}", + "description": "Article: accessible name for the comment avatar" + }, "VkAnvv": { "defaultMessage": "Envoyer", "description": "ContactForm: send button" @@ -523,6 +527,10 @@ "defaultMessage": "Blocs de code :", "description": "PrismThemeToggle: theme label" }, + "gYbxP4": { + "defaultMessage": "Les commentaires sont en cours de chargement…", + "description": "LoadingPageComments: loading message" + }, "hGvQpI": { "defaultMessage": "Charger plus d’articles ?", "description": "PostsList: load more button" @@ -619,6 +627,10 @@ "defaultMessage": "Découvrez les résultats de recherche pour {query} sur {websiteName}.", "description": "SearchPage: SEO - Meta description" }, + "s57FTB": { + "defaultMessage": "Partager", + "description": "Article: sharing widget title" + }, "s8/tyz": { "defaultMessage": "Sujet :", "description": "ContactForm: object label" -- cgit v1.2.3