From 891441a76173c708c6604fa203b175aefa222333 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Mon, 9 Oct 2023 16:31:00 +0200 Subject: refactor(components): rewrite Branding component The component should only be responsible of the layout for the logo, the name and the optional baseline. Also, the homepage url could be different from `/` so the consumer should give the right url. --- .../organisms/layout/site-header.stories.tsx | 15 +++++++-------- .../organisms/layout/site-header.test.tsx | 22 +++++++++------------- 2 files changed, 16 insertions(+), 21 deletions(-) (limited to 'src/components/organisms/layout') diff --git a/src/components/organisms/layout/site-header.stories.tsx b/src/components/organisms/layout/site-header.stories.tsx index 2b57263..e69ebfd 100644 --- a/src/components/organisms/layout/site-header.stories.tsx +++ b/src/components/organisms/layout/site-header.stories.tsx @@ -1,6 +1,6 @@ import type { ComponentMeta, ComponentStory } from '@storybook/react'; import NextImage from 'next/image'; -import { Logo } from '../../atoms'; +import { Heading } from '../../atoms'; import { SiteHeader as SiteHeaderComponent } from './site-header'; /** @@ -149,15 +149,14 @@ const nav = [ */ export const SiteHeader = Template.bind({}); SiteHeader.args = { - logo: , nav, - photo: ( + logo: ( ), - title: 'Website title', + name: Website title, }; diff --git a/src/components/organisms/layout/site-header.test.tsx b/src/components/organisms/layout/site-header.test.tsx index dc0e00d..fa1b7be 100644 --- a/src/components/organisms/layout/site-header.test.tsx +++ b/src/components/organisms/layout/site-header.test.tsx @@ -1,7 +1,6 @@ import { describe, expect, it } from '@jest/globals'; import NextImage from 'next/image'; import { render, screen as rtlScreen } from '../../../../tests/utils'; -import { Logo } from '../../atoms'; import { SiteHeader } from './site-header'; const nav = [ @@ -18,20 +17,18 @@ describe('SiteHeader', () => { render( } - motionStorageKey="reduced-motion" - nav={nav} - photo={ + logo={ } + motionStorageKey="reduced-motion" + name={

{title}

} + nav={nav} searchPage="#" - title={title} /> ); expect( @@ -43,10 +40,7 @@ describe('SiteHeader', () => { render( } - motionStorageKey="reduced-motion" - nav={nav} - photo={ + logo={ { width={200} /> } + motionStorageKey="reduced-motion" + name={
{title}
} + nav={nav} searchPage="#" - title={title} /> ); expect(rtlScreen.getByRole('navigation')).toBeInTheDocument(); -- cgit v1.2.3