From 36890cfafeba6e30782df1260d7f9e678c7da4bf Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Mon, 2 Oct 2023 17:01:57 +0200 Subject: refactor(components): rewrite DescriptionList component * add a `spacing` prop * replace `layout` prop with `isInline` prop * remove `items` prop (and classNames props) in favor of new components: Description, Group, Term * remove `withSeparator` prop (CSS content is announced by screen readers and Firefox/Safari have no support for alternative text so the consumer should add itself an element with `aria-hidden` if it need a separator) Be aware, Meta component and its consumers can be visually broken, they should be refactored before using them in production. --- src/components/organisms/layout/comments-list.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/components/organisms/layout/comments-list.tsx') diff --git a/src/components/organisms/layout/comments-list.tsx b/src/components/organisms/layout/comments-list.tsx index 103bfb4..af0152a 100644 --- a/src/components/organisms/layout/comments-list.tsx +++ b/src/components/organisms/layout/comments-list.tsx @@ -1,14 +1,15 @@ import type { FC } from 'react'; import type { SingleComment } from '../../../types'; import { List, ListItem } from '../../atoms'; - -// eslint-disable-next-line @typescript-eslint/no-shadow -import { Comment, type CommentProps } from './comment'; +import { UserComment, type UserCommentProps } from './comment'; // eslint-disable-next-line @typescript-eslint/no-magic-numbers export type CommentsListDepth = 0 | 1 | 2 | 3 | 4; -export type CommentsListProps = Pick & { +export type CommentsListProps = Pick< + UserCommentProps, + 'Notice' | 'saveComment' +> & { /** * An array of comments. */ @@ -44,7 +45,7 @@ export const CommentsList: FC = ({ return commentsList.map(({ replies, ...comment }) => ( -