From 7255d25f6834a208c0ed44636356cc260f6ab6ba Mon Sep 17 00:00:00 2001
From: Armand Philippot <git@armandphilippot.com>
Date: Wed, 27 Sep 2023 17:38:23 +0200
Subject: refactor(components): rewrite Heading component

* remove `alignment` and `withMargin` props (consumer should handle
that)
* move styles to Sass placeholders to avoid repeats with headings
coming from WordPress
* refactor some other components that depend on Heading to avoid ESlint
errors
---
 src/components/molecules/buttons/heading-button.tsx | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

(limited to 'src/components/molecules/buttons/heading-button.tsx')

diff --git a/src/components/molecules/buttons/heading-button.tsx b/src/components/molecules/buttons/heading-button.tsx
index 93ccdbe..97e2c84 100644
--- a/src/components/molecules/buttons/heading-button.tsx
+++ b/src/components/molecules/buttons/heading-button.tsx
@@ -1,4 +1,4 @@
-import { FC, SetStateAction } from 'react';
+import { useCallback, type FC, type SetStateAction } from 'react';
 import { useIntl } from 'react-intl';
 import { Heading, type HeadingProps, PlusMinus } from '../../atoms';
 import styles from './heading-button.module.scss';
@@ -35,6 +35,7 @@ export const HeadingButton: FC<HeadingButtonProps> = ({
   title,
 }) => {
   const intl = useIntl();
+  const btnClass = `${styles.wrapper} ${className}`;
   const iconState = expanded ? 'minus' : 'plus';
   const titlePrefix = expanded
     ? intl.formatMessage({
@@ -48,13 +49,15 @@ export const HeadingButton: FC<HeadingButtonProps> = ({
         id: 'bcyOgC',
       });
 
+  const toggleExpand = useCallback(
+    () => setExpanded((prev) => !prev),
+    [setExpanded]
+  );
+
   return (
-    <button
-      className={`${styles.wrapper} ${className}`}
-      onClick={() => setExpanded(!expanded)}
-      type="button"
-    >
-      <Heading level={level} withMargin={false} className={styles.heading}>
+    <button className={btnClass} onClick={toggleExpand} type="button">
+      <Heading className={styles.heading} level={level}>
+        {/* eslint-disable-next-line react/jsx-no-literals -- SR class allowed */}
         <span className="screen-reader-text">{titlePrefix} </span>
         {title}
       </Heading>
-- 
cgit v1.2.3

td class='form'><form class='right' method='get' action='/www.armandphilippot.com/log/src/components/atoms/loaders/spinner.module.scss'>
<input type='hidden' name='h' value='v1.1.0'/><input type='hidden' name='id' value='0d59a6d2995b4119865271ed1908ede0bb96497c'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/www.armandphilippot.com/tree/?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>root</a>/<a href='/www.armandphilippot.com/tree/src?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>src</a>/<a href='/www.armandphilippot.com/tree/src/components?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>components</a>/<a href='/www.armandphilippot.com/tree/src/components/atoms?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>atoms</a>/<a href='/www.armandphilippot.com/tree/src/components/atoms/loaders?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>loaders</a>/<a href='/www.armandphilippot.com/tree/src/components/atoms/loaders/spinner.module.scss?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>spinner.module.scss</a></div><div class='content'>blob: 8d818a2c82e7dfaf97914a38d8fb21fbc60a9d7b (<a href='/www.armandphilippot.com/plain/src/components/atoms/loaders/spinner.module.scss?h=v1.1.0&amp;id=0d59a6d2995b4119865271ed1908ede0bb96497c'>plain</a>)
<table summary='blob content' class='blob'>
<tr><td class='linenumbers'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
</pre></td>
<td class='lines'><pre><code>