From f861e6a269ba9f62700776d3cd13b644a9e836d4 Mon Sep 17 00:00:00 2001 From: Armand Philippot Date: Wed, 20 Sep 2023 16:38:54 +0200 Subject: refactor: use named export for everything except pages Next expect a default export for pages so only those components should use default exports. Everything else should use named exports to reduce the number of import statements. --- src/components/atoms/images/index.ts | 1 + src/components/atoms/images/logo.stories.tsx | 2 +- src/components/atoms/images/logo.test.tsx | 2 +- src/components/atoms/images/logo.tsx | 13 ++++++------- 4 files changed, 9 insertions(+), 9 deletions(-) create mode 100644 src/components/atoms/images/index.ts (limited to 'src/components/atoms/images') diff --git a/src/components/atoms/images/index.ts b/src/components/atoms/images/index.ts new file mode 100644 index 0000000..cb6151d --- /dev/null +++ b/src/components/atoms/images/index.ts @@ -0,0 +1 @@ +export * from './logo'; diff --git a/src/components/atoms/images/logo.stories.tsx b/src/components/atoms/images/logo.stories.tsx index 458ec08..bf19b34 100644 --- a/src/components/atoms/images/logo.stories.tsx +++ b/src/components/atoms/images/logo.stories.tsx @@ -1,5 +1,5 @@ import { ComponentMeta, ComponentStory } from '@storybook/react'; -import LogoComponent from './logo'; +import { Logo as LogoComponent } from './logo'; /** * Logo - Storybook Meta diff --git a/src/components/atoms/images/logo.test.tsx b/src/components/atoms/images/logo.test.tsx index e56a737..81aec3a 100644 --- a/src/components/atoms/images/logo.test.tsx +++ b/src/components/atoms/images/logo.test.tsx @@ -1,5 +1,5 @@ import { render, screen } from '../../../../tests/utils'; -import Logo from './logo'; +import { Logo } from './logo'; describe('Logo', () => { it('renders a logo with a title', () => { diff --git a/src/components/atoms/images/logo.tsx b/src/components/atoms/images/logo.tsx index 3978882..491539d 100644 --- a/src/components/atoms/images/logo.tsx +++ b/src/components/atoms/images/logo.tsx @@ -1,7 +1,7 @@ -import { FC } from 'react'; +import { FC, SVGAttributes } from 'react'; import styles from './logo.module.scss'; -export type LogoProps = { +export type LogoProps = SVGAttributes & { /** * SVG Image title. */ @@ -13,14 +13,15 @@ export type LogoProps = { * * Render a SVG logo. */ -const Logo: FC = ({ title }) => { +export const Logo: FC = ({ title, ...props }) => { return ( - {title && {title}} + {title ? {title} : null} = ({ title }) => { ); }; - -export default Logo; -- cgit v1.2.3