From fb860884857da73ee5b5e897745301cdf1d770a2 Mon Sep 17 00:00:00 2001
From: Armand Philippot <git@armandphilippot.com>
Date: Thu, 5 Oct 2023 18:58:30 +0200
Subject: refactor(components): make form components compliant with Eslint
 rules

---
 src/components/atoms/forms/fields/select/select.stories.tsx |  4 ++--
 src/components/atoms/forms/fields/select/select.test.tsx    |  6 +++---
 src/components/atoms/forms/fields/select/select.tsx         | 11 ++---------
 3 files changed, 7 insertions(+), 14 deletions(-)

(limited to 'src/components/atoms/forms/fields/select')

diff --git a/src/components/atoms/forms/fields/select/select.stories.tsx b/src/components/atoms/forms/fields/select/select.stories.tsx
index c9e02d2..fddf354 100644
--- a/src/components/atoms/forms/fields/select/select.stories.tsx
+++ b/src/components/atoms/forms/fields/select/select.stories.tsx
@@ -1,5 +1,5 @@
-import { ComponentMeta, ComponentStory } from '@storybook/react';
-import { ChangeEvent, useCallback, useState } from 'react';
+import type { ComponentMeta, ComponentStory } from '@storybook/react';
+import { type ChangeEvent, useCallback, useState } from 'react';
 import { Select as SelectComponent } from './select';
 
 const selectOptions = [
diff --git a/src/components/atoms/forms/fields/select/select.test.tsx b/src/components/atoms/forms/fields/select/select.test.tsx
index ae76c45..821a9aa 100644
--- a/src/components/atoms/forms/fields/select/select.test.tsx
+++ b/src/components/atoms/forms/fields/select/select.test.tsx
@@ -1,5 +1,5 @@
 import { describe, expect, it } from '@jest/globals';
-import { render, screen } from '../../../../../../tests/utils';
+import { render, screen as rtlScreen } from '@testing-library/react';
 import { Select } from './select';
 
 const doNothing = () => {
@@ -25,7 +25,7 @@ describe('Select', () => {
       />
     );
 
-    expect(screen.getByRole('combobox')).toHaveValue(selected.value);
+    expect(rtlScreen.getByRole('combobox')).toHaveValue(selected.value);
   });
 
   it('renders the select options', () => {
@@ -39,6 +39,6 @@ describe('Select', () => {
       />
     );
 
-    expect(screen.getAllByRole('option')).toHaveLength(selectOptions.length);
+    expect(rtlScreen.getAllByRole('option')).toHaveLength(selectOptions.length);
   });
 });
diff --git a/src/components/atoms/forms/fields/select/select.tsx b/src/components/atoms/forms/fields/select/select.tsx
index 887dacc..7399727 100644
--- a/src/components/atoms/forms/fields/select/select.tsx
+++ b/src/components/atoms/forms/fields/select/select.tsx
@@ -1,4 +1,4 @@
-import { FC, SelectHTMLAttributes } from 'react';
+import type { FC, SelectHTMLAttributes } from 'react';
 import styles from '../fields.module.scss';
 
 export type SelectOptions = {
@@ -18,7 +18,7 @@ export type SelectOptions = {
 
 export type SelectProps = Omit<
   SelectHTMLAttributes<HTMLSelectElement>,
-  'disabled' | 'hidden' | 'required'
+  'disabled' | 'required'
 > & {
   /**
    * Should the select field be disabled?
@@ -26,12 +26,6 @@ export type SelectProps = Omit<
    * @default false
    */
   isDisabled?: boolean;
-  /**
-   * Should the select field be hidden?
-   *
-   * @default false
-   */
-  isHidden?: boolean;
   /**
    * Is the select field required?
    *
@@ -52,7 +46,6 @@ export type SelectProps = Omit<
 export const Select: FC<SelectProps> = ({
   className = '',
   isDisabled = false,
-  isHidden = false,
   isRequired = false,
   options,
   ...props
-- 
cgit v1.2.3