diff options
| author | Armand Philippot <git@armandphilippot.com> | 2022-06-07 17:36:46 +0200 |
|---|---|---|
| committer | Armand Philippot <git@armandphilippot.com> | 2022-06-07 17:41:43 +0200 |
| commit | b1103a9554c5593c065466d1e289db2680cf2993 (patch) | |
| tree | 3e786789f8dfdb42d9e524171d2dfa5812c1fff0 /src/components/atoms/loaders/progress-bar.tsx | |
| parent | 234b67fe98c6167e4f83f43e11942a9e937c2a60 (diff) | |
chore: add a label to progress bar
The progress element is a form element, so a label is required to be
accessible. Since I'm not using it without label, I transform the
optional info parameter to a mandatory label parameter.
Diffstat (limited to 'src/components/atoms/loaders/progress-bar.tsx')
| -rw-r--r-- | src/components/atoms/loaders/progress-bar.tsx | 26 |
1 files changed, 15 insertions, 11 deletions
diff --git a/src/components/atoms/loaders/progress-bar.tsx b/src/components/atoms/loaders/progress-bar.tsx index 9bac847..60c585a 100644 --- a/src/components/atoms/loaders/progress-bar.tsx +++ b/src/components/atoms/loaders/progress-bar.tsx @@ -3,17 +3,17 @@ import styles from './progress-bar.module.scss'; export type ProgressBarProps = { /** - * Accessible progress bar name. - */ - 'aria-label'?: string; - /** * Current value. */ current: number; /** - * Additional information to display before progress bar. + * The progress bar id. + */ + id: string; + /** + * The progress bar label. */ - info?: string; + label: string; /** * Minimal value. */ @@ -31,23 +31,27 @@ export type ProgressBarProps = { */ const ProgressBar: FC<ProgressBarProps> = ({ current, - info, + id, + label, min, max, - ...props }) => { return ( <div className={styles.progress}> - {info && <div className={styles.progress__info}>{info}</div>} + <label htmlFor={id} className={styles.progress__info}> + {label} + </label> <progress className={styles.progress__bar} + id={id} max={max} value={current} aria-valuemin={min} aria-valuemax={max} aria-valuenow={current} - {...props} - ></progress> + > + {current}/{max} + </progress> </div> ); }; |
